Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.sh python3-pymodbus #114

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

borpin
Copy link
Contributor

@borpin borpin commented Jul 1, 2020

Add python3-pymodbus required for TCP interfacer.

Add python3-pymodbus required for TCP interfacer.
@alexandrecuer
Copy link
Contributor

are yu sure ?
I am using the modbus interfacer heavily and I do :

pip3 install -U pymodbus

cf https://github.com/riptideio/pymodbus#installing

@borpin
Copy link
Contributor Author

borpin commented Jul 1, 2020

General advice seems to be to use apt where possible as the version is tested with that distribution. pip should be used where the module is not available from apt - emon/OEM are not consistent on that.

In addition, past installs have been done with sudo pip which is again incorrect but difficult to fix going forward.

@alexandrecuer
Copy link
Contributor

alexandrecuer commented Jul 1, 2020 via email

@borpin
Copy link
Contributor Author

borpin commented Jul 2, 2020

pi@emonpi:~ $ apt-cache search python3-serial
python3-serial - pyserial - module encapsulating access for the serial port

@danbates2
Copy link
Contributor

How about sticking apt-get install rpi.gpio in here too?

@borpin
Copy link
Contributor Author

borpin commented Jul 2, 2020

I used python3-gpiozero - which is better?

@borpin borpin changed the title Update install.sh Update install.sh python3-pymodbus Jul 2, 2020
@borpin
Copy link
Contributor Author

borpin commented Jul 2, 2020

Actually, leave this alone and add to the Pulse Interfacer PR - actually it is already there.

@danbates2
Copy link
Contributor

cool.

@TrystanLea TrystanLea merged commit f1db187 into openenergymonitor:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants