Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional log messege to debug threading #15

Merged
merged 1 commit into from
Nov 13, 2016

Conversation

@glynhudson glynhudson merged commit 683c569 into openenergymonitor:emon-pi Nov 13, 2016
@glynhudson
Copy link
Member

Thanks, users will be able to updat to this version by running emonpi update. Do you think we should bump the version number so we will be able to tell from the log file if user is running this updated version? I've recently added ability to download full emonhub logs from within emoncms

@pb66
Copy link
Contributor Author

pb66 commented Nov 14, 2016

Thanks Glyn, No I don't think a version bump is required, it is easy to tell if this is the revision being used as the log message prior to this point was "Sent to channel' : ", where as for here forward the log messages are "Sent to channel(start)' : " and "Sent to channel(end)' : ".

Plus hopefully one of these can be removed down the line as it is a bit of logging overkill once this issue is resolved, I only submitted it as a PR so emonSD users didn't need to get involved with editing the emonhub files manually on a user by user basis, possibly upsetting future git updates in the process.

@glynhudson
Copy link
Member

Yes, good idea. Thanks a lot for helping to try and solve this issue.
Strangely only seems to effect some users, I have been unable to recreate.
Have you noticed the issues effects RFM69Pi users more than emonPi users?

On Monday, 14 November 2016, Paul notifications@github.com wrote:

Thanks Glyn, No I don't think a version bump is required, it is easy to
tell if this is the revision being used as the log message prior to this
point was "Sent to channel' : ", where as for here forward the log messages
are "Sent to channel(start)' : " and "Sent to channel(end)' : ".

Plus hopefully one of these can be removed down the line as it is a bit of
logging overkill once this issue is resolved, I only submitted it as a PR
so emonSD users didn't need to get involved with editing the emonhub files
manually on a user by user basis, possibly upsetting future git updates in
the process.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#15 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAuUPEjeQrFx3qyOKzhHw5bR3jVO6sr-ks5q-DRwgaJpZM4KwbCo
.

Glyn Hudson

http://megni.co.uk
http://adventuresplusnorthwales.blogspot.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants