Merge master to stable #154
Conversation
Fixes #141
…d a couple of try/excepts with error messages See https://community.openenergymonitor.org/t/newbie-needs-hand-holding/16475?u=pb66
Fix reply http interfacer
Update to support Sharky 775
Users sometimes make a typo in the config where they mean to set datacodes to a list but instead set datacode. Log a warning and return error.
… ziporah-goodwe-5ket
…nto bwduncan-modbustcp-fix
…porah-influxdb
| ] | ||
|
|
||
| if len(c.realdata)>0: | ||
| if r: |
There was a problem hiding this comment.
Can r be False in any reasonable situation? Why not just return in the exception handler above? Unless read_all can return, e.g., [] or None then this is just overcomplicating things.
There was a problem hiding this comment.
I've added your comment here as an inline comment for now, I will come back to this when I next work on this interfacer and have everything in front of me to test, thanks!
| if r: | ||
| try: | ||
| for i in read_keys: | ||
| if i in r: |
There was a problem hiding this comment.
Instead of for i in read_keys, this should use something like for i, (name, scale) in read_keys.items(), rather than using [0] and [1] to index the tuple which is pretty unreadable.
There was a problem hiding this comment.
same as above, thanks!
|
Some more comments added. Thanks @TrystanLea 😄 |
|
Thanks @bwduncan ! 👍 |
Add the requirement for the data string to start with `MSG:xx`
Add explicit instrunction that the channel definition must end with a comma.
The previously named pi3-* device tree overlays got the pi3- prefix removed when Raspberry Pi 4 was released: raspberrypi/firmware@9102977 The old names are still kept valid for backwards compatibility, but this this commit applies the new names, to keep the script future-prove. Signed-off-by: MichaIng <micha@dietpi.com>
Update readme.md
Update configuration.md
Update device tree overlays names
Change log: