Fix for poorly formed RSSI causing thread to crash #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://community.openenergymonitor.org/t/warning-mainthread-rfm2pi-thread-is-dead/2417?u=pb66 Added error handling and a log message for when the RSSI is not an integer.
|
Please see https://community.openenergymonitor.org/t/warning-mainthread-rfm2pi-thread-is-dead/2417?u=pb66 before merging! this is currently untested. |
|
Hi @pb66 , I have been following that thread. Nice work tracking down this issue (hopefully!) 👍 I've just tested this commit and it works fine on my emonPi. Do you think we should merge into master or commit the change to a |
|
@glynhudson, If it tests ok on your set up it should be fine to merge, I was just concerned about untested code potentially breaking working systems. if your seeing RSSI's ok then I see no reason not to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openenergymonitor.org/t/warning-mainthread-rfm2pi-thread-is-dead/2417?u=pb66
Added error handling and a log message for when the RSSI is not an integer.