Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DIP switch had no effect #2

Merged
merged 2 commits into from
Jul 26, 2017

Conversation

elias-rexometer
Copy link
Contributor

Hi Glyn,

the DIP switch was being read after rf12_initialize(nodeID, RF_freq, networkGroup);, so it couldn't change the node ID.

Best,
Elias

@elias-rexometer
Copy link
Contributor Author

added a minor fix: show version in the config function did still divide through 10 ...

@glynhudson
Copy link
Member

Hi @elias-rexometer , thanks for this. However the node ID setting on the dip switch is intentionally set before the RF is initialised since the RFM needs to be initialised with the selected node ID. The DIP switch setting is designed to be set before powering the unit up. I would prefer to keep it this way.

If you could submit another PR to fix the version number in the config, that would be great.

Thanks.

@glynhudson glynhudson closed this Jul 26, 2017
@rexometer
Copy link

rexometer commented Jul 26, 2017

Hi Glyn, I'm confused, that is exactly what this pull request is for: set the dip switch setting before the RF is initialised. Now the RF is initialised at line 202 and the DIP switch settings starts at line 205

@glynhudson
Copy link
Member

Appologies, you're totally right. I was testing with the previous FW version (3.2.1)..doh!. This bug was introduced in 3.2.2. Thanks so much for the fix 👍

@glynhudson glynhudson reopened this Jul 26, 2017
@glynhudson glynhudson merged commit 9812cc3 into openenergymonitor:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants