This repository was archived by the owner on May 24, 2022. It is now read-only.
fix: Disable Electron remote module #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelchalon
approved these changes
Sep 2, 2019
Contributor
|
Code LGTM, |
Tbaut
approved these changes
Sep 3, 2019
Collaborator
Tbaut
left a comment
Tbaut
left a comment
There was a problem hiding this comment.
I have no problem with yarn electron indeed :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #548
The issue describes filtering permissions in the
remotemodule (point 16 in https://electronjs.org/docs/tutorial/security#16-filter-the-remote-module).Instead, I did the more drastic point 15: remove altogether the
remotemodule.I would appreciate
yarn startandyarn electrontesting, they pass on my computer.