feat(gallery): Improved gallery modal captions - OEL-2129 #509
Conversation
[skip chromatic]
[skip chromatic]
|
🚀 Deployed on https://preview-509--oelibrary.netlify.app |
| @@ -14,7 +14,8 @@ | |||
| image: (string) <img> tag | |||
| caption (string) | |||
| caption_classes (string) | |||
| caption_title (string) | |||
| caption_title (string) | |||
| caption_visible_mobile (boolean) | |||
There was a problem hiding this comment.
changed the approach, now it's initialised inside the gallery and passed to the carousel.
| @@ -17,6 +17,7 @@ module.exports = { | |||
| media: `<img alt="First slide" | |||
| src="https://picsum.photos/id/1005/800/400" | |||
| />`, | |||
| caption_visible_mobile: true, | |||
There was a problem hiding this comment.
Why should I set this when passing the information about the data?
There was a problem hiding this comment.
This should be rather a parameter of the carousel, possibly marked as internal, which hides the caption on mobile. show_caption_mobile or something tied to gallery. Or better, add a block to wrap the needed code and override it when extending the carousel.
There was a problem hiding this comment.
i don't think i need an extra block, i changed the approach and the extra param comes from gallery directly and not from each single item.
| @@ -170,8 +170,6 @@ Parameters: | |||
| {% block carousel %} | |||
| {% for _item in _items %} | |||
| {% set _carousel_items = _carousel_items|merge([_item|merge({ | |||
| caption_title: ('<iframe' in _item.media or '<video' in _item.media) ? '' : _item.caption_title, | |||
| caption: ('<iframe' in _item.media or '<video' in _item.media) ? '' : _item.caption, | |||
| image: ('<iframe' in _item.media or '<img' in _item.media) ? _item.media|replace({'src=': 'data-src='}) : _item.media, | |||
There was a problem hiding this comment.
Side note: this breaks if there's another attribute like <img data-thumbnail-src="...">.
There was a problem hiding this comment.
I added an extra space to be sure src is as alone without any extra data-. Should be ok i think
[skip chromatic]
No description provided.