New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config options for db and date range #16

Merged
merged 3 commits into from May 6, 2017

Conversation

Projects
None yet
2 participants
@ahalterman
Copy link
Member

ahalterman commented May 2, 2017

Add options to the config file for db, collection, and whether to process all stories ('all') or just the ones added in the last day ('today').

Closes #15

@ahalterman ahalterman requested a review from johnb30 May 2, 2017

@johnb30

This comment has been minimized.

Copy link
Member

johnb30 commented May 4, 2017

It looks fine to me, but you might want to add some checking around the all option. For example, if the query returns a million stories, you might want to add in a pause that asks the user if they're sure they want to process all the stories. Not entirely necessary, though.

@ahalterman

This comment has been minimized.

Copy link
Member Author

ahalterman commented May 6, 2017

Done. Also cleared out some unnecessary prints and made others more informative.

@ahalterman ahalterman merged commit a293279 into master May 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment