Race condition in creation of LockedTypeMap and registerAttributeTypes

[mikearmstrong001]

Mutex will only be initialized on first call, suggestion is to move the static Mutex outside of the function.

Mike

---

IlmImf/ImfAttribute.cpp

LockedTypeMap &
typeMap ()
{
// race condition
static Mutex criticalSection;
// end race condition
Lock lock (criticalSection);

static LockedTypeMap* typeMap = 0;

if (typeMap == 0)
typeMap = new LockedTypeMap ();

return *typeMap;

}

OpenEXR/IlmImf/ImfHeader.cpp

void
staticInitialize ()
{
// race condition
static Mutex criticalSection;
// end race condition
Lock lock (criticalSection);

static bool initialized = false;

if (!initialized)
{

[cary-ilm]

Looking into the OpenEXR backlog.

This issues appears to be fixed by 00df2c7 in release v.2.3.0.