New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme/namespaces #4

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
None yet
2 participants
@alexellis
Copy link
Member

alexellis commented Jan 4, 2019

Signed-off-by: Alex Ellis (VMware) alexellis2@gmail.com

What

  • Updates references to faas to OpenFaaS

  • Clarifies Rancher 1.0, not Rancher 2.0 linking to the K8s provider

  • Adds status of project

  • Updates namespaces to correct placement on GitHub

  • Updated Docker build to Go 1.10.4 and latest Alpine image to ship in

Verification

Docker builds 馃憤 Tests pass 馃憤

Update readme/namespaces
Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>

@alexellis alexellis requested a review from kenfdev Jan 4, 2019

@kenfdev
Copy link
Member

kenfdev left a comment

Thanks for the change Alex! One thing. I think it's better to say Rancher 1.x rather than Rancher 1.0 because the majority is using Rancher 1.6. Same as to Rancher 2.0. The majority is using Rancher 2.1 so how about Rancher 2.x?
Other than that, it looks great and thanks for the maintenance comment.

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 5, 2019

I think that makes sense 馃憤

Alex

@kenfdev

This comment has been minimized.

Copy link
Member

kenfdev commented Jan 12, 2019

I can continue the edit about the version number but is that okay with you Alex?
Or I can wait your commit. Thank you!

@alexellis alexellis merged commit c126730 into master Jan 12, 2019

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 12, 2019

I'll merge so you can contribute the change.

@kenfdev kenfdev deleted the alexellis/readme-namespace-update branch Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment