New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update timeouts to give examples in Golang durations #46
Conversation
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. |
Derek set title: update timeouts to give examples in Golang durations |
All timeout values need to be specified in Golang durations. Please feel free to use community support if you get stuck in the future :-) https://docs.openfaas.com/community No question too small to be asked there. Out of curiosity what were you attempting to do? Alex |
Hi Alex, Thanks! And yeah, I should've, hahaha. We're using openfaas-of in front of tensorflow serving, so that's also why I needed to extend the default timeout. It's not a super-long running process, but model inference takes some time. The reason for using openfaas-of is that loading a model using the fork method takes a lot of time. For some other bits of our AI pipeline it makes a lot more sense to fork a process and do something small - it mainly prevents a lot of overhead in our code and keeps the code simple and easy to replace with something newer or better. Such as a tokenizer for example. Does that make sense? Kind regards, Willem |
Please can you run The usecase sounds really interesting. Speak on slack? Alex |
I kind of did everything via the github website as it was a quicky - apologies. Done. |
Signed-off-by: Willem Mobach <willem.mobach@outlook.com>
Oh dear that didn't go very well. We can't accept the merge commit. Just use git reset and push it up again or let me know if you want me to do the git piece. |
Thanks for your patience! |
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
git commit -s