Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secrets filter functionality for GitLab #84

Merged
merged 2 commits into from Mar 16, 2019

Conversation

Projects
None yet
3 participants
@martindekov
Copy link
Member

martindekov commented Mar 14, 2019

Adding secrets filtering for GitLab and changing
the functionality to determine whether GitLab or
GitHub secrets will be created on the scm field
in the init.yaml file. Also adding unit test
along with fixing existing ones and fixing
couple of spelling mistakes

Signed-off-by: Martin Dekov mdekov@vmware.com

Description

In PR #46 @ivanayov Implemented GitLab integration for bootstrapping. The change applies filters to her gitlab integration

How Has This Been Tested?

Manually tested secret creation when in init.yml file

...
scm: gitlab
...

and

...
scm: github
...

to see the secrets created depending on the filter.

Checklist:

I have:

  • checked my changes follow the style of the existing code / OpenFaaS repos
  • updated the documentation and/or roadmap in README.md
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests
Show resolved Hide resolved main.go
Show resolved Hide resolved main_test.go
Show resolved Hide resolved main_test.go
@alexellis
Copy link
Member

alexellis left a comment

LGTM Martin

Do you want to do anything re: comments from @ivanayov before I merge?

@martindekov

This comment has been minimized.

Copy link
Member Author

martindekov commented Mar 14, 2019

Yeah @alexellis I will reference the comments. @ivanayov thanks for the review I will add changes to your comments. 👍

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Mar 15, 2019

Looking forward to it @martindekov

@martindekov

This comment has been minimized.

Copy link
Member Author

martindekov commented Mar 16, 2019

Hey Alex I responded to Ivana's comments otherwise I think this is ready to be merged 👍

martindekov added some commits Mar 14, 2019

Add secrets filter functionality for GitLab
Adding secrets filtering for GitLab and changing
the functionality to determine whether GitLab or
GitHub secrets will be created on the scm field
in the init.yaml file. Also adding unit test
along with fixing existing ones and fixing
couple of spelling mistakes

Signed-off-by: Martin Dekov <mdekov@vmware.com>
Change naming of constants
Changing the naming to the constants
as they began to feel confusing. So now
GitLabFilter stands for `scm_gitlab` and
GitLabSCM stands for 'gitlab' how we configure
the SCM field in the yaml file. The same
for GitHub

Signed-off-by: Martin Dekov <mdekov@vmware.com>

@martindekov martindekov force-pushed the martindekov:martindekov/add_gitlab_filters_functionality branch from c5312fe to 543785c Mar 16, 2019

@alexellis
Copy link
Member

alexellis left a comment

Approved.

@alexellis alexellis merged commit e1b85f0 into openfaas-incubator:master Mar 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Mar 16, 2019

Thank you Martin. Publishing a binary release now. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.