New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local namespaces.yml during k8s deployment #108

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@johnmccabe
Copy link
Member

johnmccabe commented Jan 1, 2019

Description

This updates the Kubernetes kubectl deployment steps, to use the local namespaces.yml from the cloned faas-netes repo rather than pulling from GitHub.

Motivation and Context

  • I have raised an issue to propose this change (n/a)

Since we clone faas-netes and use it for all other yml it makes more sense to use the local namespaces.yml.

How Has This Been Tested?

Deployed using these steps on local k8s, also visual inspection of docs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
Use local namespaces.yml
Signed-off-by: John McCabe <john@johnmccabe.net>
@alexellis
Copy link
Member

alexellis left a comment

I actually made the change specifically for this since it matches the approach with helm.

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 10, 2019

John,

I'm going to close this as per my comment. I would be open to changing my mind in the future if there was a good case for it. Thanks for your help making the OpenFaaS experience even better.

Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment