New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about GKE load-balancer default timeouts #112

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@rgee0
Copy link
Member

rgee0 commented Jan 10, 2019

Signed-off-by: Richard Gee richard@technologee.co.uk

Description

At the time of writing the default load-balancer timeout within GKE is 30 seconds. This change adds notes within the Kubernetes deployment guide and the troubleshooting section to highlight that there may be timeout configuration outside of OpenFaaS while also drawing attention specifically to GKE.

Motivation and Context

See openfaas/faas#1016

How Has This Been Tested?

Docs change. Peer review to ensue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

@rgee0 rgee0 force-pushed the rgee0:gcptimeouts branch 2 times, most recently from 8e17192 to 244a285 Jan 10, 2019

Add notes about GKE load-balancer default timeouts
At the time of writing the default load-balancer timeout within GKE is 30 seconds.  This change adds notes within the Kubernetes deployment guide and the troubleshooting section to highlight that there may be timeout configuration outside of OpenFaaS while also drawing attention specifically to GKE.

Signed-off-by: Richard Gee <richard@technologee.co.uk>

@rgee0 rgee0 force-pushed the rgee0:gcptimeouts branch from 244a285 to 4d97687 Jan 10, 2019

@burtonr
Copy link
Member

burtonr left a comment

Clear and concise. This will probably prevent quite a few headaches!

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 10, 2019

Good addition.

@alexellis alexellis closed this Jan 10, 2019

@alexellis alexellis reopened this Jan 10, 2019

@alexellis alexellis merged commit 10d5dd6 into openfaas:master Jan 10, 2019

1 check passed

deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment