New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Support build-time labels for Docker images #567

Open
alexellis opened this Issue Dec 5, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@alexellis
Member

alexellis commented Dec 5, 2018

As a faas-cli user I would like to provide a series of labels to be built into my Docker images so that I can identify, catalog and organize my images.

This feature was suggested by "zeeque" on Slack who works at e2x.com.

An example is http://label-schema.org/rc1/

Expected Behaviour

faas-cli up  \
  --build-label build-date=org.label-schema.build-date="2016-04-12T23:20:50.52Z"
  --build-label vcs-url=org.label-schema.vcs-url="https://github.com/nginx/nginx"

We may also want to place these labels in YAML files such as:

  ruby-echo:
    lang: ruby
    handler: ./sample/ruby-echo
    image: alexellis/ruby-echo:0.2
    build_labels:
      - build-date=org.label-schema.build-date="2016-04-12T23:20:50.52Z"
      - vcs-url=org.label-schema.vcs-url="https://github.com/nginx/nginx"

There may be a place in the YAML schema where we can collate these new types of labels and the existing build_options overrides.

Current Behaviour

These labels could only be added manually, not via the faas-cli build / up flow which may make our tooling less useful for those already adopting label schema and other build-time labels for their Docker images.

Possible Solution

As suggested above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment