New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TLS warning into const #581

Open
alexellis opened this Issue Jan 10, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@alexellis
Copy link
Member

alexellis commented Jan 10, 2019

Expected Behaviour

The following string is repeated in several places, especially when we merge all the remaining secrets features such as #580

"WARNING! Communication is not secure, please consider using HTTPS. Letsencrypt.org offers free SSL/TLS certificates.

Possible Solution

We should extract these messages into a const within the package they live in. If they live in both, then maybe they should go in a common existing package?

@viveksyngh

This comment has been minimized.

Copy link
Member

viveksyngh commented Jan 10, 2019

Like this there are few more error messages that we can refactor, they are mostly part of the proxy functions.

@mario-mazo

This comment has been minimized.

Copy link

mario-mazo commented Jan 11, 2019

I would like to take this one

@mario-mazo mario-mazo referenced this issue Jan 12, 2019

Open

Moved TLS warnings to its own package #585

5 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment