Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rio to faas-cli generate #640

Open
alexellis opened this issue May 24, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@alexellis
Copy link
Member

commented May 24, 2019

Expected Behaviour

The following should generate a Rancher Rio Service definition:

faas-cli generate --api=services.rio.cattle.io
apiVersion: rio.cattle.io/v1
kind: Service
metadata:
  name: figlet
  namespace: default
spec:
  concurrency: 10
  cpus: "0"
  env:
  - name: a
    value: b
  image: functions/figlet:latest
  imagePullPolicy: IfNotPresent
  maxScale: 1
  minScale: 1
  ports:
  - port: 8080
    protocol: HTTP
    targetPort: 8080
  rollout: true
  rolloutIncrement: 5
  rolloutInterval: 5
  scale: 1
  weight: 100

Current Behaviour

We have OpenFaaS CRD and Knative Serving CRD in place. I'd like to see the Rio CRD there next.

Possible Solution

Copy the approach used for the current generation as per: https://github.com/openfaas/faas-cli/blob/master/commands/generate.go#L164

Set all default / minimum needed to get a service running.

  • Install K8s somewhere
  • Install Rio - https://github.com/rancher/rio
  • Try kubectl apply for the sample YAML above
  • Next update the faas-cli code to generate Service YAML
@dpen2000

This comment has been minimized.

Copy link

commented May 24, 2019

I'll take a look at this, @alexellis

@alexellis

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

I'm quite keen to get this done quickly. Once you've had a look please can you reply if you can work on it and when you think that you may have a PR up?

The port is always fixed as: 8080

We have ways to translate the OpenFaaS scaling parameters but I am OK with just replicating the above YAML 1:1 with all the defaults for the first iteration then, we can improve on that. Secrets are also not needed for this PR.

@alexellis

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

We will definitely need the env.

@dpen2000 dpen2000 referenced a pull request that will close this issue May 28, 2019

Open

Add rio v1 to generate CRD commands #642

4 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.