Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Default to a 'well-known' named stack file #71

Closed
0xdevalias opened this issue Sep 4, 2017 · 8 comments
Closed

Proposal: Default to a 'well-known' named stack file #71

0xdevalias opened this issue Sep 4, 2017 · 8 comments

Comments

@0xdevalias
Copy link

Expected Behaviour

In a similar vein to docker compose it would be nice if faas-cli defaulted to a well-known, named yaml file (eg openfaas.yml or similar) If it did, it wouldn't be a requirement to specify -f foo.yaml on each CLI command.

@alexellis
Copy link
Member

Good suggestion. We were talking about this recently. I think stack.yml or functions.yml could be a good name.

Are you interested in completing the work also?

@johnmccabe - can the -f flag be adapted to take a default easily?

@0xdevalias
Copy link
Author

At this stage i'm not sure if I have the capacity to contribute, though if I find I do down the line and it isn't implemented yet, happy to take a shot at it then.

@johnmccabe
Copy link
Contributor

johnmccabe commented Sep 4, 2017

@alexellis that should be straight forward, the only bit that is worth calling out is the expected behaviour when passing explicit flags and no -f|--yaml as that logic will be impacted. The use of a default was mentioned in the examples in #17 but we'd decided against it at the time.

Goes without saying I'm a +1 on the idea.

@alexellis alexellis changed the title Default to a 'well-known' named stack file (eg. openfaas.yml) Proposal: Default to a 'well-known' named stack file (eg. openfaas.yml) Sep 4, 2017
@alexellis
Copy link
Member

bit that is worth calling out is the expected behaviour when passing explicit flags and no -f|--yaml as that logic will be impacted.

Can you give an example?

@alexellis
Copy link
Member

I would see this as being "stack.yml". We have to make sure that the override works well with all the commands before merging a fix.

@nicholasjackson
Copy link
Contributor

I can take a look at this in the morning

@alexellis alexellis changed the title Proposal: Default to a 'well-known' named stack file (eg. openfaas.yml) Proposal: Default to a 'well-known' named stack file Sep 25, 2017
@0xdevalias
Copy link
Author

See #126

@alexellis
Copy link
Member

This has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants