New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faas secret remove command #579

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
1 participant
@alexellis
Copy link
Member

alexellis commented Jan 10, 2019

Add faas secret remove command

Signed-off-by: Alex Ellis (VMware) alexellis2@gmail.com

Description

  • adds secret remove command

Motivation and Context

  • I have raised an issue to propose this change (required)

Contributes to #577

How Has This Been Tested?

  • adds unit tests to validate arguments list

Tested with faas-netes as back-end and latest YAML files in ./yaml/

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Add faas secret remove command
- adds unit tests to validate arguments list
- adds secret remove command

Tested with faas-netes

Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 10, 2019

CI passes, I'll merge.

@alexellis alexellis merged commit 6c4bcb6 into master Jan 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexellis alexellis deleted the alexellis/secret-rm-command branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment