Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename provider YAML name from faas to openfaas #609

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@alexellis
Copy link
Member

alexellis commented Mar 6, 2019

Signed-off-by: Alex Ellis alexellis2@gmail.com

Description

Rename provider YAML faas to openfaas

Motivation and Context

The provider name value of faas is archaic and should be changed
to openfaas. The CLI code already supports this but the generated
values use the text faas still.

How Has This Been Tested?

    1. Running this in the faas-cli folder:
faas-cli up
    1. Running ./make_dist.sh
    1. Generating and running up on a new function with the updated binary:

Example:

provider:
  name: openfaas
  gateway: http://127.0.0.1:8080
functions:
  name:
    lang: go
    handler: ./name
    image: name:latest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Rename provider YAML faas to openfaas
The provider name value of faas is archaic and should be changed
to openfaas. The CLI code already supports this but the generated
values use the text faas still.

Signed-off-by: Alex Ellis <alexellis2@gmail.com>

@alexellis alexellis changed the title Rename provider YAML faas to openfaas Rename provider YAML name from faas to openfaas Mar 6, 2019

@alexellis alexellis requested a review from viveksyngh Mar 6, 2019

@viveksyngh
Copy link
Member

viveksyngh left a comment

LGTM .. I also tested with mentioned test steps.

@alexellis

This comment has been minimized.

Copy link
Member Author

alexellis commented Mar 6, 2019

Thank you

@alexellis alexellis merged commit bcff3a6 into master Mar 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.