Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add template pull stack #668
Adding tempalte pull stack command which will pull tempaltes
Signed-off-by: Martin Dekov firstname.lastname@example.org
The output is in the following format when
Motivation and Context
How Has This Been Tested?
Manual testing, I mostly used already existing functionality which is unit tested.
Types of changes
I have started testing it manually,
I left other specific comments as line comments on the diff
It is actually my fault @LucasRoesler, sorry about that, forgot to answer the question, yes if you set custom name, only the template with that key will be downloaded.
If you skip the name, all the templates will be downloaded.
@martindekov I don't think the name filter is working as expected. I have a template repo with two templates, but if I specify the name filter, I would expect it to only copy one of the templates, right?
Other than this, everything works as I would expect it
Adding tempalte pull stack command which will pull tempaltes from configuration field in the function yaml or from separate yaml file with that same field Signed-off-by: Martin Dekov <email@example.com>
As discussed in the channel, changed the
I appreciate @martindekov working hard on this and the other people reviewing the code.
I can't get to this yet, but I want to play with it and see if it makes sense before making it permanent.
I am still slightly uncomfortable with this being in stack.yml, I feel like it belongs outside and the save feature adds weight to that. I may be wrong, I've been wrong before.
Yeah, of course, no problems, when you can. Ping me when you have solid sight on this feature.
Saving would move out the logic from
The current change is MVP and only enables you to have your templates listed in a yaml file, instead of
What about priority - i.e. check store first, then check for a URL?
I would expect that I could do something like: