Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review: AvailableReplica / replicaStatus via Eric #150

Merged
merged 3 commits into from Mar 1, 2018
Merged

Code review: AvailableReplica / replicaStatus via Eric #150

merged 3 commits into from Mar 1, 2018

Conversation

alexellis
Copy link
Member

@alexellis alexellis commented Mar 1, 2018 •
edited

Description

Code review / additional changes via #67 / @ericstoekl

Review

Concerns / updates

  • Changed to use AvailableReplicas
  • Moved to vendored gateway package version 0.7.3

screen shot 2018-03-01 at 08 40 05

screen shot 2018-03-01 at 08 40 01

Closes #67

ericstoekl and others added 3 commits February 3, 2018 15:03
@ericstoekl
Add Replica Status count and expose as AvailableCount
87abcc9 
Signed-off-by: Eric Stoekl <ems5311@gmail.com>
@ericstoekl
Use 'availableReplicas' instead of 'replicaCount'
853343e 
Signed-off-by: Eric Stoekl <ems5311@gmail.com>
@alexellis
Code review: re-vendor and update to AvailableReplicas
9fae1ca 
Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
@alexellis alexellis changed the title Replica status review Code review: AvailableReplica / replicaStatus via Eric Mar 1, 2018
@alexellis
Copy link
Member Author

alexellis commented Mar 1, 2018 •
edited

Thanks @ericstoekl for leading this - your commits have been retained in my subsequent PR.

@alexellis alexellis merged commit 71ece71 into master Mar 1, 2018
@alexellis alexellis deleted the replicaStatusReview branch December 20, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexellis @ericstoekl