New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nil secrets handler #343

Merged
merged 1 commit into from Jan 5, 2019

Conversation

Projects
None yet
2 participants
@alexellis
Copy link
Member

alexellis commented Jan 4, 2019

Signed-off-by: Alex Ellis (VMware) alexellis2@gmail.com

Description

Add nil secrets handler

  • updates faas-provider to 0.8.0
  • adds the secrets handler, but as not implemented

Motivation and Context

  • I have raised an issue to propose this change (required)

Closes #341

How Has This Been Tested?

Tested via go build / CI.

E2e testing will also be carried out before merge.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Add nil secrets handler
- updates faas-provider to 0.8.0
- adds the secrets handler, but as not implemented

Tested via go build / CI.

Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>

@alexellis alexellis requested a review from LucasRoesler Jan 4, 2019

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 4, 2019

Test image will be: openfaas/faas-netes:0.6.4-rc1

@LucasRoesler
Copy link
Member

LucasRoesler left a comment

LGTM

@alexellis alexellis merged commit 7a756b2 into master Jan 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 5, 2019

Thank you !

@alexellis alexellis deleted the alexellis/add-secrets-shim branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment