Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Use Kubernetes discovery for Gateway Prometheus scrapping #363
This PR does the following:
Motivation and Context
How Has This Been Tested?
Helm install tested on GKE with Istio 1.0.3 and two Gateway pods
Types of changes
Please can you confirm if the name or labels of metrics has changed by switching to this mode of discovery?
Maybe showing the Grafana dashboard from the labs would be sufficient?
Hi Stefan thank you for updating and testing the newer version. Please could you look at my comments about the istio changes? ideally I would prefer to take these in a separate PR and have an issue explaining more about the context.
Thanks again for your contribution