Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emptyDir mount to Prometheus #394

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
2 participants
@alexellis
Copy link
Member

alexellis commented Mar 27, 2019

Signed-off-by: Alex Ellis alexellis2@gmail.com

Description

  • added to helm Chart and plain YAML to enable OpenShift to work
    without patching YAML manually.
  • Tested with YAML method.

Motivation and Context

  • I have raised an issue to propose this change (required)

Partial fix of #349

How Has This Been Tested?

Via kubectl apply on a kind v1.12 cluster

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Add emptyDir mount to Prometheus
- added to helm Chart and plain YAML to enable OpenShift to work
without patching YAML manually.
- Tested with YAML method.

Signed-off-by: Alex Ellis <alexellis2@gmail.com>
@stefanprodan
Copy link
Member

stefanprodan left a comment

LGTM

@alexellis

This comment has been minimized.

Copy link
Member Author

alexellis commented Mar 27, 2019

Thanks

@alexellis alexellis merged commit 2aca1a5 into master Mar 27, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexellis alexellis deleted the alexellis/add_empty_dir_to_prom branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.