Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HTTP probe by default #465

Merged
merged 4 commits into from Jul 3, 2019
Merged

Enable HTTP probe by default #465

merged 4 commits into from Jul 3, 2019

Conversation

alexellis
Copy link
Member

@alexellis alexellis commented Jul 3, 2019

Signed-off-by: Alex Ellis alexellis2@gmail.com

Description

Enable HTTP probe by default

Motivation and Context

  • I have raised an issue to propose this change (required)

Fixes #466

This will reduce user-facing CPU usage.

Change also increases function polling time to 2s to reduce
the CPU overhead. Users can set this to 1s for faster cold-starts.

How Has This Been Tested?

Tested with common function store images. Some older images will need to be rebuilt by the user.

I would recommend that we introduce a flag that can set the probe type on a per-function basis for backwards-compatibility.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This will reduce user-facing CPU usage.

Change also increases function polling time to 2s to reduce
the CPU overhead. Users can set this to 1s for faster cold-starts.

Signed-off-by: Alex Ellis <alexellis2@gmail.com>
Signed-off-by: Alex Ellis <alexellis2@gmail.com>
Signed-off-by: Alex Ellis <alexellis2@gmail.com>
Advised by @stefanprodan to make this change.

Signed-off-by: Alex Ellis <alexellis2@gmail.com>
@alexellis alexellis merged commit ead0d07 into master Jul 3, 2019
@alexellis
Copy link
Member Author

Thanks both 👍

@alexellis alexellis deleted the http-probe-by-default branch July 3, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High CPU reported from default execProbes
3 participants