New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem of returning nil instead of empty array #44

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
2 participants
@bartsmykla
Copy link
Member

bartsmykla commented Jan 11, 2019

When there is no secrets right now instead of nil
endpoint will return empty array

Signed-off-by: Bart Smykla bsmykla@vmware.com

Description

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartsmykla bartsmykla changed the title Fixed probloem of returning nil instead of empty array Fixed problem of returning nil instead of empty array Jan 11, 2019

Fixed problem of returning nil instead of empty array
When there is no secrets right now instead of nil
endpoint will return empty array

Signed-off-by: Bart Smykla <bsmykla@vmware.com>

@bartsmykla bartsmykla force-pushed the bartsmykla:bugfix/get-secrets-nil-instead-of-empty-array branch from e7d0a5c to 8c27200 Jan 11, 2019

@alexellis alexellis merged commit 3cac0cc into openfaas:master Jan 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bartsmykla bartsmykla deleted the bartsmykla:bugfix/get-secrets-nil-instead-of-empty-array branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment