New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update watchdog usages to 0.9.14 #1022

Open
alexellis opened this Issue Jan 10, 2019 · 6 comments

Comments

Projects
None yet
2 participants
@alexellis
Copy link
Member

alexellis commented Jan 10, 2019

Expected Behaviour

Update watchdog usages to 0.9.14 for sample functions

Current Behaviour

These are running slightly behind.

Possible Solution

Update the Dockerfiles / references and then run faas-cli build to check for typos etc.

@roncrivera

This comment has been minimized.

Copy link
Contributor

roncrivera commented Jan 10, 2019

Hi @alexellis , please assign this to me. Thanks!

@roncrivera

This comment has been minimized.

Copy link
Contributor

roncrivera commented Jan 11, 2019

Ronald-Riveras-MacBook-Pro:faas ron$ find . -type f ! -path "./.git/*" -exec grep -H '/0.9.[0-9]' {} \; | grep -v '0.9.14'
./DEV.md:ADD https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog /usr/bin
./DEV.md:ADD https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog /usr/bin
./DEV.md:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./DEV.md:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/AlpineFunction/Dockerfile.arm64:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog-arm64 > /usr/bin/fwatchdog \
./sample-functions/AlpineFunction/Dockerfile.armhf:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog-armhf > /usr/bin/fwatchdog \
./sample-functions/ApiKeyProtected-Secrets/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/BaseFunctions/cobol/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/BaseFunctions/coffee/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/BaseFunctions/dncore/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/BaseFunctions/golang/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/BaseFunctions/golang/Dockerfile.win:ADD https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog.exe /watchdog.exe
./sample-functions/BaseFunctions/java/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/BaseFunctions/node/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/BaseFunctions/python/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/BaseFunctions/R/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/CaptainsIntent/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/ChangeColorIntent/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/CHelloWorld/src/Dockerfile:    && curl -SL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/DockerHubStats/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/DockerHubStats/Dockerfile.armhf:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog-armhf > /usr/bin/fwatchdog \
./sample-functions/figlet/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/figlet/Dockerfile.armhf:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog-armhf > /usr/bin/fwatchdog \
./sample-functions/gif-maker/Dockerfile:    && curl -LS https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/HostnameIntent/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/MarkdownRender/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/NodeInfo/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/NodeInfo/Dockerfile.arm64:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog-arm64 > /usr/bin/fwatchdog \
./sample-functions/NodeInfo/Dockerfile.armhf:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog-armhf > /usr/bin/fwatchdog \
./sample-functions/Phantomjs/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/ResizeImageMagick/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/ResizeImageMagick/Dockerfile.armhf:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog-armhf > /usr/bin/fwatchdog \
./sample-functions/SentimentAnalysis/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./sample-functions/SentimentAnalysis/Dockerfile.armhf:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog-armhf > /usr/bin/fwatchdog \
./sample-functions/WebhookStash/Dockerfile:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./watchdog/README.md:ADD https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog /usr/bin
./watchdog/README.md:    && curl -sL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 11, 2019

Great, please can you raise a pull request for this?

@roncrivera roncrivera referenced this issue Jan 11, 2019

Closed

Update watchdog to 0.9.14 for sample functions #1024

3 of 11 tasks complete
@roncrivera

This comment has been minimized.

Copy link
Contributor

roncrivera commented Jan 11, 2019

Raised PR #1024. CI build is GREEN.

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 12, 2019

I've commented.

@roncrivera roncrivera referenced this issue Jan 13, 2019

Merged

Update watchdog to 0.9.14 for sample functions #1028

4 of 11 tasks complete
@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 16, 2019

Hi @roncrivera can you do a quick search to see which watchdog versions may be left if any? (remember they won't all be at 0.9.6 so regex/search is a bit more involved)

Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment