New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: move /metrics to a separate HTTP port #1081

Open
alexellis opened this Issue Feb 7, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@alexellis
Copy link
Member

alexellis commented Feb 7, 2019

Task

We should move the /metrics/ path scraped by Prometheus for internal use to a separate HTTP port. This separates concerns.

Possible Solution

  • Figure out the port we want to use (not 8081, since that clashes with the provider)
  • Add another HTTP server
  • Bind the handler from Prometheus
  • Update helm chart, YAML and docker-compose for all platforms.
  • Test end to end
@viveksyngh

This comment has been minimized.

Copy link
Member

viveksyngh commented Feb 9, 2019

I would like to work on this one.

@alexellis

This comment has been minimized.

Copy link
Member Author

alexellis commented Feb 9, 2019

You can assign it with Derek

@viveksyngh

This comment has been minimized.

Copy link
Member

viveksyngh commented Feb 9, 2019

Derek assign: me

viveksyngh added a commit to viveksyngh/faas that referenced this issue Feb 13, 2019

Add new HTTPServer to serve /metrics on port 8082
This commit runs a new HTTPServer on port 8082 in a goroutine to serve
/metrics endpoint on a different port.

This also update the configurations and compose files.

Fixes: openfaas#1081

Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in>

viveksyngh added a commit to viveksyngh/faas that referenced this issue Feb 13, 2019

Add new HTTPServer to serve /metrics on port 8082
This commit runs a new HTTPServer on port 8082 in a goroutine to serve
/metrics endpoint on a different port.

This also update the configurations and compose files.

Fixes: openfaas#1081

Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in>

@viveksyngh viveksyngh referenced a pull request that will close this issue Feb 13, 2019

Open

[WIP] Add new HTTPServer to serve /metrics on port 8082 #1085

4 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment