New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/merge Secrets CRUD #1012

merged 5 commits into from Jan 4, 2019


None yet
3 participants
Copy link

alexellis commented Jan 4, 2019


Motivation and Context

  • I have raised an issue to propose this change (required)

Closes #968

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)


  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

acornies added some commits Nov 17, 2018

Initial support for secrets in gw:
- added SecretHandler type
- added discussed system/secret endpoint with appropriate http verbs

Signed-off-by: Andrew Cornies <>
Secrets iteration:
- added delete http verb to system/secrets
- added secrets request type
- added vagrant env provisioned by existing

Signed-off-by: Andrew Cornies <>
Updates from PR comments:
- moved Vagrantfile to contrib dir
- gave secret request type more thought

Signed-off-by: Andrew Cornies <>
Updated secret types based on PR feedback:
- SecretInfo type
- ListSecretsResponse
- Move Annotations to SecretInfo
- update swagger api docs

Signed-off-by: Andrew Cornies <>
type: array
$ref: '#/definitions/ListSecretsResponse'

This comment has been minimized.


stefanprodan Jan 4, 2019


All refs should point to '#/definitions/Secret'

This comment has been minimized.


alexellis Jan 4, 2019


Agreed. PTAL in my second commit

@stefanprodan stefanprodan referenced this pull request Jan 4, 2019


Add secret struct #14

Update swagger for missing secret definitions
- added secret definition and removed types used previously

Remove structs for secrets

- after discussion on PR the core contributors decided we just
want simple CRUD with the Secret type.

Signed-off-by: Alex Ellis (VMware) <>

@alexellis alexellis force-pushed the alexellis/secrets_crud branch from ea04c27 to f5fbd4b Jan 4, 2019

@alexellis alexellis merged commit a65df47 into master Jan 4, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
continuous-integration/travis-ci/push The Travis CI build passed

@alexellis alexellis deleted the alexellis/secrets_crud branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment