New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped version of faas-swarm to 0.6.1 and gateway to: 0.9.14 #1020

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
2 participants
@bartsmykla
Copy link
Member

bartsmykla commented Jan 10, 2019

I changed the version of image to current one,
which implements secret management endpoint (openfaas/faas-swarm#42)
from 0.5.0 to 0.6.1 in docker-compose.yml (x86_64)

Also version of gateway was bumped from 0.9.11 to 0.9.14 (x86_64)

Signed-off-by: Bart Smykla bsmykla@vmware.com

Description

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

I fired ./deploy_stack.sh on my local machine

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 10, 2019

Can you do me a quick favor before I merge this? It's OK if you do it tomorrow.

Create a secret using CURL then list and delete it via the CLI and paste the output here.

Thanks,

Alex

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Jan 10, 2019

I'm on it now, one sec

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Jan 10, 2019

➜  ~ docker secret ls
ID                          NAME                  DRIVER              CREATED             UPDATED
pd9n452sxbd7a8hovu8zro2ui   basic-auth-password                       2 days ago          2 days ago
ekw7mkxk06ydo9qs03u7qq0lg   basic-auth-user                           2 days ago          2 days ago
yl71oi13rxe30gh3izfapu778   test3                                     2 days ago          2 days ago
➜  ~ curl -d '{"name":"foo","value":"test"}' -X POST http://localhost:8080/system/secrets
➜  ~ docker secret ls
ID                          NAME                  DRIVER              CREATED             UPDATED
pd9n452sxbd7a8hovu8zro2ui   basic-auth-password                       2 days ago          2 days ago
ekw7mkxk06ydo9qs03u7qq0lg   basic-auth-user                           2 days ago          2 days ago
xi8d447xpp7i2uqppq52hf5id   foo                                       4 seconds ago       4 seconds ago
yl71oi13rxe30gh3izfapu778   test3                                     2 days ago          2 days ago
➜  ~ curl -X GET http://localhost:8080/system/secrets
[{"name":"foo"},{"name":"test3"}]%
➜  ~ curl -d '{"name":"foo"}' -X DELETE http://localhost:8080/system/secrets
➜  ~ curl -X GET http://localhost:8080/system/secrets
[{"name":"test3"}]%
➜  ~ curl -d '{"name":"test3"}' -X DELETE http://localhost:8080/system/secrets
➜  ~ curl -X GET http://localhost:8080/system/secrets
null%
@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 11, 2019

This doesn't look right:

curl -X GET http://localhost:8080/system/secrets
null

I would expect to see an empty slice/array returned. I'll also check faas-netes / the operator

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Jan 11, 2019

I'm checking it

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 11, 2019

The operator has the same issue @stefanprodan @LucasRoesler of giving null when we have no secrets in the list.

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Jan 11, 2019

@alexellis fixed:

➜  faas git:(feature/faas-swarm-version-bump) ✗ curl -X GET http://localhost:8080/system/secrets
[]% 
@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 11, 2019

What did you need to change as I'm looking at it in faas-netes too?

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Jan 11, 2019

Instead of var results []requests.Secret I used: results := []requests.Secret{}

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 11, 2019

(Actually I think it's the operator which has the issue, not faas-netes.)

Thanks for fixing here. I'll merge your PR and do a point release then can you bump it here?

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Jan 11, 2019

Sure!

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Jan 11, 2019

@alexellis There is a PR for that change: openfaas/faas-swarm#44

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 11, 2019

Release ready if you want to bump up your version: https://github.com/openfaas/faas-swarm/releases/tag/0.6.1

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Jan 11, 2019

I'm on it

@bartsmykla bartsmykla force-pushed the bartsmykla:feature/faas-swarm-version-bump branch from 420c879 to 095fe92 Jan 11, 2019

@bartsmykla bartsmykla changed the title Bumped version of faas-swarm to 0.6.0 Bumped version of faas-swarm to 0.6.0 and gateway to: 0.9.14 Jan 11, 2019

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Jan 11, 2019

@alexellis I bumped the version of faas-swarm and also bumped the gateway to 0.9.14

@bartsmykla bartsmykla changed the title Bumped version of faas-swarm to 0.6.0 and gateway to: 0.9.14 Bumped version of faas-swarm to 0.6.1 and gateway to: 0.9.14 Jan 11, 2019

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 11, 2019

Do we have a CI error @bartsmykla ?

@bartsmykla bartsmykla force-pushed the bartsmykla:feature/faas-swarm-version-bump branch from 095fe92 to 4850c56 Jan 11, 2019

Bumped version of faas-swarm to 0.6.1
I changed the version of image to current one,
which implements secret management endpoint
from 0.5.0 to 0.6.1 in docker-compose.yml (x86_64)

Version of openfaas/gateway was also increased to 0.9.14

Signed-off-by: Bart Smykla <bsmykla@vmware.com>

@bartsmykla bartsmykla force-pushed the bartsmykla:feature/faas-swarm-version-bump branch from 4850c56 to 9917295 Jan 11, 2019

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Jan 11, 2019

@alexellis My bad. It's fixed now

@alexellis
Copy link
Member

alexellis left a comment

LGTM

@alexellis alexellis merged commit 954b683 into openfaas:master Jan 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bartsmykla bartsmykla deleted the bartsmykla:feature/faas-swarm-version-bump branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment