Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 KubeCon video links to community file #1389

Merged
merged 2 commits into from Mar 5, 2020
Merged

Add 3 KubeCon video links to community file #1389

merged 2 commits into from Mar 5, 2020

Conversation

burtonr
Copy link
Contributor

@burtonr burtonr commented Nov 26, 2019

Signed-off-by: Burton Rheutan rheutan7@gmail.com

Description

Add video links to Kubecon talks in the community file

Some of the talks were already present with a link to the event, so I've just added an additional link to the existing row for the video so as not to lose the event information.

If you'd rather have duplicated records, one for the event, and one for the video, I'm happy to refactor this change. Perhaps the video link could go into the "writeups" section with some of the other videos.

Motivation and Context

  • I have raised an issue to propose this change (required)
  • My issue has received approval from the maintainers or lead with the design/approved label
    Spoke with Alex via Slack

How Has This Been Tested?

Verified the links were functional and previewed the markdown rendering with VSCode

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@alexellis
Copy link
Member

Can these go into a featured video section instead please?

@alexellis
Copy link
Member

@burtonr please see my comment.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than altering the links / adding, please create a new section under the awards/mentions.

@alexellis
Copy link
Member

@burtonr

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment.

Signed-off-by: Burton Rheutan <rheutan7@gmail.com>
@derek derek bot added the no-dco label Feb 23, 2020
@derek
Copy link

derek bot commented Feb 23, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot removed the no-dco label Feb 23, 2020
Signed-off-by: Burton Rheutan <rheutan7@gmail.com>
@burtonr
Copy link
Contributor Author

burtonr commented Feb 23, 2020

@alexellis I've added the featured videos section. I chose not to remove the same record from the events list as I feel it belongs in both places. If someone is looking for a talk from a certain date, they may not know to look for it in the "Featured Videos" section, likewise, someone looking for a video may not know to look in the events section.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis
Copy link
Member

I can only see the featured videos section (added), which is what I was hoping to see.

@alexellis alexellis merged commit 326cc7a into openfaas:master Mar 5, 2020
@burtonr burtonr deleted the add-videos branch March 5, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants