New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3 KubeCon video links to community file #1389
Conversation
Can these go into a featured video section instead please? |
@burtonr please see my comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than altering the links / adding, please create a new section under the awards/mentions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comment.
Signed-off-by: Burton Rheutan <rheutan7@gmail.com>
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Signed-off-by: Burton Rheutan <rheutan7@gmail.com>
@alexellis I've added the featured videos section. I chose not to remove the same record from the events list as I feel it belongs in both places. If someone is looking for a talk from a certain date, they may not know to look for it in the "Featured Videos" section, likewise, someone looking for a video may not know to look in the events section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I can only see the featured videos section (added), which is what I was hoping to see. |
Signed-off-by: Burton Rheutan rheutan7@gmail.com
Description
Add video links to Kubecon talks in the community file
Some of the talks were already present with a link to the event, so I've just added an additional link to the existing row for the video so as not to lose the event information.
If you'd rather have duplicated records, one for the event, and one for the video, I'm happy to refactor this change. Perhaps the video link could go into the "writeups" section with some of the other videos.
Motivation and Context
design/approved
labelSpoke with Alex via Slack
How Has This Been Tested?
Verified the links were functional and previewed the markdown rendering with VSCode
Types of changes
Checklist:
git commit -s