Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] - Feature/secret management to facilitate proposal #807 #968
This is the first round of changes to facilitate a simpler way of managing secrets by adding a new route and secret handler to be implemented in each respective provider.
Motivation and Context
From proposal #807
How Has This Been Tested?
Not fully tested yet, only manual integration tests done in Vagrant/Docker Swarm environment. TODO: add integration tests in pre-defined location
AFAICT: This feature introduces a new handler for the providers to implement CLUD on secrets: faas-netes,swarm,nomad, faas-provider? faas-cli functionality also needs to be implemented (another PR outside of this scope)
Types of changes
This should have a update to the swagger spec in the
One thing that I thought about while reviewing this is that the List endpoint might want to support filtering. There is no way to specify this in the go code here because those values would live in the GET parameters. But if we are keeping the swagger spec up-to-date, that spec should include a definition of the filter parameters that should be supported by the provider.