Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upTask: validate CUSTOMERS file before use #391
Comments
alexellis
added
good first issue
skill/beginner
size/xs
labels
Feb 6, 2019
This comment has been minimized.
This comment has been minimized.
The PR should be raised here: https://github.com/openfaas/openfaas-cloud/tree/master/sdk |
This comment has been minimized.
This comment has been minimized.
No need to test end-to-end, just via unit tests. |
This comment has been minimized.
This comment has been minimized.
how about
and
|
This comment has been minimized.
This comment has been minimized.
What about it? |
This comment has been minimized.
This comment has been minimized.
alexe won't clash because of the separator being |
This comment has been minimized.
This comment has been minimized.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
alexellis commentedFeb 6, 2019
Expected Behaviour
We should validate all entries in the CUSTOMERS file before use - to prevent anyone getting their functions overriden by accident. See issue #314
Possible Solution
Since this is relying on a human element of not merging a PR to the customers file with two potentially clashing usernames, we should implement a unit test and sdk method in the sdk of OpenFaaS Cloud that can validate a list of usernames.
I.e.
OK
Not OK
Not OK
OK