New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/logout #295

Merged
merged 2 commits into from Jan 14, 2019

Conversation

Projects
None yet
4 participants
@bartsmykla
Copy link
Member

bartsmykla commented Oct 15, 2018

Description

Added Logout button in header's navbar which is calling /logout endpoint which is overriding openfaas_cloud_token cookie.
Closes #283
Closes #256

How Has This Been Tested?

Manually tried signing in and out few times using logout button in nav bar and also pure endpoint.

How are existing users impacted? What migration steps/scripts do we need?

There is no need to do migration.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests
@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Oct 16, 2018

Have you got a screenshot?

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Oct 16, 2018

image

Show resolved Hide resolved dashboard/stack.yml Outdated
@alexellis
Copy link
Member

alexellis left a comment

Minor edit requested.

@bartsmykla bartsmykla force-pushed the bartsmykla:feature/logout branch 3 times, most recently from 988e483 to 6bc03c0 Oct 18, 2018

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Oct 18, 2018

@alexellis can you check again if everything is fine now?

@burtonr

This comment has been minimized.

Copy link
Member

burtonr commented Nov 15, 2018

@bartsmykla There are some conflicts now 😦 Could you look at getting those resolved?

From what I can tell, the updates will satisfy @alexellis comments, but need to get the conflicts resolved first.

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Nov 16, 2018

Please rebase

@bartsmykla bartsmykla force-pushed the bartsmykla:feature/logout branch 2 times, most recently from 5551fa4 to ae8207e Nov 22, 2018

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Nov 22, 2018

@alexellis @burtonr rebased and fixed all things from comments

@bartsmykla bartsmykla force-pushed the bartsmykla:feature/logout branch 2 times, most recently from da6d499 to 891fcf2 Dec 10, 2018

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Dec 19, 2018

Rebase needed here -> Conflicting files: dashboard/of-cloud-dashboard/handler.js

@bartsmykla bartsmykla force-pushed the bartsmykla:feature/logout branch from 891fcf2 to 0f65298 Dec 19, 2018

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Dec 19, 2018

@alexellis rebased

@bartsmykla bartsmykla force-pushed the bartsmykla:feature/logout branch from 0f65298 to 2c7e92b Jan 3, 2019

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Jan 3, 2019

Rebased again

bartsmykla added some commits Oct 15, 2018

Visual changes for logout
Prepared views for logout when you are logged in using OAuth

Signed-off-by: Bart Smykla <bsmykla@vmware.com>
Exposing endpoint for logout
Expose endpoint /logout which is removing 'openfaas_cloud_token' cookie

Signed-off-by: Bart Smykla <bsmykla@vmware.com>

@bartsmykla bartsmykla force-pushed the bartsmykla:feature/logout branch from 2c7e92b to 0c84dfe Jan 9, 2019

@bartsmykla

This comment has been minimized.

Copy link
Member

bartsmykla commented Jan 14, 2019

I have tested this PR again, and everything is working as expected.

@alexellis alexellis merged commit 4032832 into openfaas:master Jan 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 14, 2019

Thanks

@bartsmykla bartsmykla deleted the bartsmykla:feature/logout branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment