New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validation turn on by default #331

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@martindekov
Member

martindekov commented Nov 14, 2018

Turn on validation on customers and hmac by default
now you must be explicit on turning it off by setting it
to 0 or false started by @ivanayov

Signed-off-by: Martin Dekov (VMware) mdekov@vmware.com

Description

Before users had to set up explicitly the validation to true now the logic is turned around and you need to be explicit on turning it off by saying false to the variables validate_hmac and validate_customers

Closes #316

How Has This Been Tested?

Function added in sdk along with unit test

How are existing users impacted? What migration steps/scripts do we need?

N.A. For users which have their validation removed by commenting out the variable they need to set the variable to false or 0 because commented out means true now

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

@martindekov martindekov force-pushed the martindekov:martindekov/316_validation_on branch 3 times, most recently from 5d733a3 to 5c1d7c7 Nov 14, 2018

Show resolved Hide resolved import-secrets/handler.go Outdated

@martindekov martindekov force-pushed the martindekov:martindekov/316_validation_on branch 2 times, most recently from 95ae64e to 92e40d1 Nov 21, 2018

Show resolved Hide resolved github-event/handler.go Outdated
@alexellis

Changes requested, then I'll merge this.

@martindekov

This comment has been minimized.

Member

martindekov commented Nov 29, 2018

@alexellis need input on this also left a comment

@martindekov martindekov force-pushed the martindekov:martindekov/316_validation_on branch 2 times, most recently from 5edc047 to 8bb8d0d Nov 29, 2018

Make validation turn on by default
Turn on validation on customers and hmac by default
now you must be explicit on turning it off by setting it
to `0` or `false` started by @ivanayov

Signed-off-by: Martin Dekov (VMware) <mdekov@vmware.com>

@martindekov martindekov force-pushed the martindekov:martindekov/316_validation_on branch from 8bb8d0d to f8beb74 Nov 29, 2018

@martindekov

This comment has been minimized.

Member

martindekov commented Nov 29, 2018

It is done ✔️

@alexellis alexellis merged commit 4899ff2 into openfaas:master Dec 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexellis

This comment has been minimized.

Member

alexellis commented Dec 6, 2018

Please remove the HmacEnabled methods from each handler and point at the new SDK with vendoring - I'll do a release now for you.

@martindekov

This comment has been minimized.

Member

martindekov commented Dec 6, 2018

Yeah will open PR with the change

@martindekov martindekov referenced this pull request Dec 8, 2018

Open

Tracking feature: Use methods from SDK #356

0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment