New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for github-event #368

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@ivanayov
Copy link
Member

ivanayov commented Dec 18, 2018

This adds tests for github-event handler. Covers empty/non-suported event, validate customers and push event without secrets

Signed-off-by: Ivana Yovcheva iyovcheva@vmware.com

Needs SDK release from #123 for secrets in order to proceed with push and installation events.

How Has This Been Tested?

Unit tested

Checklist:

I have:

  • updated the documentation and/or roadmap (if required) N/A
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

@ivanayov ivanayov force-pushed the ivanayov:ivanayov/add-tests-gh-event branch from b7366b1 to 7ae2c71 Dec 18, 2018

Show resolved Hide resolved github-event/handler.go Outdated
Show resolved Hide resolved github-event/handler.go Outdated
Show resolved Hide resolved github-event/handler_test.go Outdated
Add test coverage for github-event
This adds tests for github-event handler.Covers empty/non-suported
event, validate customers and push event without secrets

Signed-off-by: Ivana Yovcheva <iyovcheva@vmware.com>

@ivanayov ivanayov force-pushed the ivanayov:ivanayov/add-tests-gh-event branch from 7ae2c71 to e803415 Jan 10, 2019

@ivanayov

This comment has been minimized.

Copy link
Member

ivanayov commented Jan 10, 2019

@alexellis addressed your comments

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 14, 2019

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment