New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the URL builders to SDK #371

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@martindekov
Copy link
Member

martindekov commented Dec 28, 2018

Adding the URL builders to SDK in seperate PR to
vendor them in the PR #323 once this commit
is merged/released

Signed-off-by: Martin Dekov (VMware) mdekov@vmware.com

Description

The PR is needed so the SDK is merged and released to and vendored in PR #323 and #330

How Has This Been Tested?

N.A. Added unit tests and tested the functions in PR #323

How are existing users impacted? What migration steps/scripts do we need?

N.A. - this predates #323 and #330

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests
Show resolved Hide resolved sdk/url_builders.go Outdated

@martindekov martindekov force-pushed the martindekov:martindekov/extract_url_builders_to_sdk branch 2 times, most recently from fb81268 to 825764c Jan 2, 2019

@martindekov

This comment has been minimized.

Copy link
Member

martindekov commented Jan 2, 2019

Ok Alex I amended your proposals 👍

Add the URL builders to SDK
Adding the URL builders to SDK in seperate PR to
vendor them in the PR #323 once this commit
is merged/released

Signed-off-by: Martin Dekov (VMware) <mdekov@vmware.com>

@martindekov martindekov force-pushed the martindekov:martindekov/extract_url_builders_to_sdk branch from 825764c to eb5156f Jan 2, 2019

@alexellis alexellis merged commit 3642c6e into openfaas:master Jan 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment