New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor the HMAC from SDK #373

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@martindekov
Copy link
Member

martindekov commented Jan 3, 2019

Vendoring the HMAC functions and use them
from SDK so there is no duplication

Signed-off-by: Martin Dekov (VMware) mdekov@vmware.com

Description

Merging #331 added functions to the SDK but since there was no release there was duplication so the HMAC functions existed in the SDK along with the handlers. Now the functions are removed from the handlers the SDK is vendored so the functions are used from there.

Closes #356

How Has This Been Tested?

N.A.

How are existing users impacted? What migration steps/scripts do we need?

N.A. vendor in code

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests
Vendor the HMAC from SDK
Vendoring the HMAC functions and use them
from SDK so there is no duplication

Signed-off-by: Martin Dekov (VMware) <mdekov@vmware.com>
@alexellis
Copy link
Member

alexellis left a comment

LGTM

@alexellis alexellis merged commit ad4bb62 into openfaas:master Jan 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 4, 2019

Thanks Martin :)

@martindekov

This comment has been minimized.

Copy link
Member

martindekov commented Jan 4, 2019

My pleasure !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment