New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /healthz endpoint to router and of-builder #386

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
2 participants
@viveksyngh
Copy link
Member

viveksyngh commented Jan 30, 2019

Signed-off-by: Vivek Singh vivekkmr45@yahoo.in

Description

This changes adds /healthz endpoint to router and of-builder.
Fixes: #381

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests
Add /healthz endpoint to router and of-builder
Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in>
@alexellis
Copy link
Member

alexellis left a comment

LGTM

@alexellis alexellis merged commit 0210231 into openfaas:master Feb 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Feb 3, 2019

Thanks Vivek.

You just have the ./auth/ service to cover now in a follow-up PR.

Alex

@viveksyngh

This comment has been minimized.

Copy link
Member Author

viveksyngh commented Feb 4, 2019

There is already a /healthz endpoint for auth microservice.

router.HandleFunc("/healthz/", func(w http.ResponseWriter, r *http.Request) {

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Feb 7, 2019

Perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment