Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd ARMHF/ARM64 build image support #394
Conversation
rdimitrov
added some commits
Feb 6, 2019
rdimitrov
force-pushed the
rdimitrov:rdimitrov/add-arm
branch
from
6ed92aa
to
6fa169d
Feb 7, 2019
alexellis
reviewed
Feb 8, 2019
| @@ -1,5 +1,5 @@ | |||
| FROM golang:1.10-alpine AS builder | |||
|
|
|||
| RUN apk add --no-cache g++ | |||
This comment has been minimized.
This comment has been minimized.
alexellis
reviewed
Feb 8, 2019
| @@ -1,5 +1,5 @@ | |||
| FROM golang:1.10-alpine AS builder | |||
|
|
|||
| RUN apk add --no-cache g++ | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zeerorg
referenced this pull request
Feb 11, 2019
Open
[WIP] Adding armhf support for openfaas-cloud #398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rdimitrov commentedFeb 6, 2019
•
edited
Description
publish-arm.shthat is used for building each component. This way it's easier to extend in future and it also takes into account the host architecture it's being run from.make ci-arm**-*targets in the main Makefile that trigger a build for all configured components. Or you can hop into each folder and build it separately.ci-arm-buildwas going to be enough as well since the script is aware of the host arch, but decided to keep the same make style as we have so far. This will be helpful if at some point we decide to add this repo to the more generalpublish-arm.shscript and it will work out of the box.Closes: #392
How Has This Been Tested?
Tested if the images are building successfully.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have:
git commit -s