New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARMHF/ARM64 build image support #394

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@rdimitrov
Copy link
Contributor

rdimitrov commented Feb 6, 2019

Description

  • All architectures can use the same Dockerfiles
  • Added a script similar to publish-arm.sh that is used for building each component. This way it's easier to extend in future and it also takes into account the host architecture it's being run from.
  • There are single make ci-arm**-* targets in the main Makefile that trigger a build for all configured components. Or you can hop into each folder and build it separately.
  • A simple ci-arm-build was going to be enough as well since the script is aware of the host arch, but decided to keep the same make style as we have so far. This will be helpful if at some point we decide to add this repo to the more general publish-arm.sh script and it will work out of the box.

Closes: #392

How Has This Been Tested?

Tested if the images are building successfully.

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

rdimitrov added some commits Feb 6, 2019

Add Makefile targets for ARMHF/ARM64
Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com>
Add g++ to ARM64 Dockerfiles for auth and router
Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com>

@rdimitrov rdimitrov force-pushed the rdimitrov:rdimitrov/add-arm branch from 6ed92aa to 6fa169d Feb 7, 2019

@@ -1,5 +1,5 @@
FROM golang:1.10-alpine AS builder

RUN apk add --no-cache g++

This comment has been minimized.

@alexellis

alexellis Feb 8, 2019

Member

Why do we need this?

@@ -1,5 +1,5 @@
FROM golang:1.10-alpine AS builder

RUN apk add --no-cache g++

This comment has been minimized.

@alexellis

alexellis Feb 8, 2019

Member

I can't think why we would need this?

This comment has been minimized.

@rdimitrov

rdimitrov Feb 8, 2019

Author Contributor

It fails while building the docker image otherwise

This comment has been minimized.

@rdimitrov

rdimitrov Feb 8, 2019

Author Contributor

That was happening only on ARM64 though.

@zeerorg zeerorg referenced this pull request Feb 11, 2019

Open

[WIP] Adding armhf support for openfaas-cloud #398

6 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment