New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds OpenFaaS on AWS Fargate blog post #17

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
3 participants
@ewilde
Copy link
Member

ewilde commented Aug 21, 2018

Resolves: #14

Signed-off-by: Edward Wilde ewilde@gmail.com

@derek derek bot added the new-contributor label Aug 21, 2018

@ewilde ewilde changed the title Adds OpenFaaS on AWS Fargate blog post [WIP] Adds OpenFaaS on AWS Fargate blog post Aug 21, 2018

@ewilde ewilde force-pushed the ewilde:ewilde-blog branch from d3d40b8 to 6df9334 Sep 25, 2018

@derek derek bot added the no-dco label Sep 25, 2018

@derek

This comment was marked as resolved.

Copy link

derek bot commented Sep 25, 2018

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

@ewilde ewilde force-pushed the ewilde:ewilde-blog branch from 6df9334 to d377c71 Oct 14, 2018

@ewilde ewilde force-pushed the ewilde:ewilde-blog branch from f879d0b to 686ce27 Dec 22, 2018

@derek derek bot removed the no-dco label Dec 22, 2018

@ewilde ewilde force-pushed the ewilde:ewilde-blog branch from 686ce27 to 795f896 Dec 22, 2018

Show resolved Hide resolved docker-compose.yml Outdated

@ewilde ewilde force-pushed the ewilde:ewilde-blog branch 4 times, most recently from 0a35f42 to bed4798 Dec 22, 2018

@ewilde ewilde changed the title [WIP] Adds OpenFaaS on AWS Fargate blog post Adds OpenFaaS on AWS Fargate blog post Dec 22, 2018

@ewilde

This comment has been minimized.

Copy link
Member Author

ewilde commented Dec 22, 2018

@alexellis PTAL

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Feb 4, 2019

Hi @ewilde would you consider this post up to date and ready to publish? Can you fix the rebase conflicts too, please?

Alex

@ewilde ewilde force-pushed the ewilde:ewilde-blog branch from 51db38c to 42333fb Feb 4, 2019

@alexellis alexellis requested review from johnmccabe and rgee0 Feb 4, 2019

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Feb 4, 2019

@johnmccabe & @rgee0 could you give the post a pass please? No need to test the commands.

@ewilde ewilde force-pushed the ewilde:ewilde-blog branch from 42333fb to 64ab0f0 Feb 4, 2019

@ewilde

This comment has been minimized.

Copy link
Member Author

ewilde commented Feb 4, 2019

Hi @ewilde would you consider this post up to date and ready to publish? Can you fix the rebase conflicts too, please?

Alex

@alexellis yes up to date, ready to publish and rebased

@rgee0
Copy link
Member

rgee0 left a comment

Hello Ed.

There are quite a few changes but they are mostly typo/grammar rather than structural and some are repeated.

Do you have an idea of indicative costs? As a reference Stefan did something similar on the GKE article.

One further comment is I wonder whether we should offer some ideas of what the reader could do with this once they're up and running - taking it further ideas? Could they run through the workshop for instance? We should also include the standard bullets about how to connect and contribute.

It'd be good to get this out Thursday 07/02 if you have time to fix up by then?

Show resolved Hide resolved _posts/2018-08-19-openfaas-on-fargate.md Outdated
Show resolved Hide resolved _posts/2018-08-19-openfaas-on-fargate.md Outdated
Show resolved Hide resolved _posts/2018-08-19-openfaas-on-fargate.md Outdated
Show resolved Hide resolved _posts/2018-08-19-openfaas-on-fargate.md Outdated
Show resolved Hide resolved _posts/2018-08-19-openfaas-on-fargate.md Outdated
Show resolved Hide resolved _posts/2018-08-19-openfaas-on-fargate.md Outdated
Show resolved Hide resolved _posts/2018-08-19-openfaas-on-fargate.md Outdated
Show resolved Hide resolved _posts/2018-08-19-openfaas-on-fargate.md Outdated
Show resolved Hide resolved _posts/2018-08-19-openfaas-on-fargate.md Outdated
Show resolved Hide resolved _posts/2018-08-19-openfaas-on-fargate.md Outdated
@derek

This comment was marked as resolved.

Copy link

derek bot commented Feb 11, 2019

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --sign-off and then git push --force.

@derek derek bot added the no-dco label Feb 11, 2019

@ewilde ewilde force-pushed the ewilde:ewilde-blog branch from a2172be to b5b0fdd Feb 11, 2019

@derek derek bot removed the no-dco label Feb 11, 2019

Adds OpenFaaS on AWS Fargate blog post
Resolves #14

Signed-off-by: Edward Wilde <ewilde@gmail.com>

@ewilde ewilde force-pushed the ewilde:ewilde-blog branch from b5b0fdd to 5189480 Feb 11, 2019

@alexellis alexellis merged commit 5516d98 into openfaas:master Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment