New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding myself by request from Alex. #48

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
2 participants
@acornies
Copy link
Member

acornies commented Jan 12, 2019

I've added my information to the members section along with supporting assets.

@derek derek bot added the invalid label Jan 12, 2019

@derek

This comment has been minimized.

Copy link

derek bot commented Jan 12, 2019

Thank you for your contribution. I've just checked and your Pull Request doesn't appear to have any description.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

@alexellis
Copy link
Member

alexellis left a comment

Do you want to customise your blurb info?

@acornies

This comment has been minimized.

Copy link
Member Author

acornies commented Jan 12, 2019

Sure, one moment.

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 12, 2019

Derek remove label: invalid

@derek derek bot removed the invalid label Jan 12, 2019

@alexellis
Copy link
Member

alexellis left a comment

Sorry this has a conflict now that needs to be rebased via the git CLI

@derek

This comment has been minimized.

Copy link

derek bot commented Jan 12, 2019

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

@derek derek bot added the no-dco label Jan 12, 2019

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Jan 12, 2019

We can't accept merge commits in PRs. Instead use rebasing - reset the commits back to HEAD on origin/master then apply your changes on top.

@acornies

This comment has been minimized.

Copy link
Member Author

acornies commented Jan 12, 2019

Totally, this was pure laziness on my part with the github UI.

Adding myself in members and blurb.
Signed-off-by: Andrew Cornies <acornies@gmail.com>

@acornies acornies force-pushed the acornies:master branch from 9551ae6 to 7f317d1 Jan 12, 2019

@derek derek bot removed the no-dco label Jan 12, 2019

@alexellis
Copy link
Member

alexellis left a comment

Approved 👍

@alexellis alexellis merged commit c013566 into openfaas:master Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment