New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial IconScout post #66

Merged
merged 2 commits into from Feb 7, 2019

Conversation

Projects
None yet
4 participants
@alexellis
Copy link
Member

alexellis commented Feb 6, 2019

Signed-off-by: Alex Ellis alexellis2@gmail.com

@alexellis

This comment has been minimized.

Copy link
Member Author

alexellis commented Feb 6, 2019

Action items Tarun:

  • Run through every step, without skipping any or assuming anything
  • Images as png (maybe capture again)
  • Check the intro prose about I/S
  • Pick a lead image for the blog post
  • Link to your avatar image please. (done)

@tarunmangukiya PTAL

@LucasRoesler
Copy link
Member

LucasRoesler left a comment

Tarun, this looks great. I am going to walk through your instructions to help double check that everything works as expected. I only had one other comment, which I made inline.

Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated

```bash
$ cd ~/dev/resizer/
$ faas-cli up -f image-resize.yml

This comment has been minimized.

@LucasRoesler

LucasRoesler Feb 6, 2019

Member

It is possible for this up command to fail. If the user is at or over their private repository limit on Docker Hub, it will accept the first docker image push but then fail on subsequent image pushes until they make they make the corresponding image repository public. I am not sure if this should be noted here, but it is possible for people to have issues at this step.


(IMAGE)

Try it out live with your own OpenFaaS where `$OPENFAAS_URL` is the IP address and port of your gateway. On Swarm this is usually `http://127.0.0.1:8080`

This comment has been minimized.

@LucasRoesler

LucasRoesler Feb 6, 2019

Member

You could use faas-cli invoke with the --query flag to do this.

echo ""  | faas-cli -f image-resize.yml invoke image-resize  --query height=300 --query width=300 --query url=https://upload.wikimedia.org/wikipedia/commons/3/36/Hopetoun_falls.jpg > output.jpg

You can then open output.jpg to verify that it is correct.

This comment has been minimized.

@tarunmangukiya

tarunmangukiya Feb 6, 2019

Yees this can be more useful. @alexellis

Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated
Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated
Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated
Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md
Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated
Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md
Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated
$ cd ~/dev/resizer/image-resizer
npm install --save sharp
```
We’ll also need the request package to fetch the specified image from its URL.

This comment has been minimized.

@rgee0

rgee0 Feb 6, 2019

Member

from the provided URL?

Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated
Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated
@tarunmangukiya
Copy link

tarunmangukiya left a comment

Have sent you images over slack.

Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated
Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated
Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated
Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated
Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated
Show resolved Hide resolved _posts/2019-02-08-resize-images-on-the-fly.md Outdated
* OpenFaaS
* faas-cli
* [`npm` and `node`](https://nodejs.org/en/download/)

This comment has been minimized.

@tarunmangukiya
@alexellis

This comment has been minimized.

Copy link
Member Author

alexellis commented Feb 7, 2019

@LucasRoesler thanks for taking a look 👍

@alexellis

This comment has been minimized.

Copy link
Member Author

alexellis commented Feb 7, 2019

@rgee0 thanks too. I've resolved all the comment and will push another commit, then add in Tarun's images sent over Slack.

@alexellis

This comment has been minimized.

Copy link
Member Author

alexellis commented Feb 7, 2019

@tarunmangukiya have you cleared all the action items on the linked issue?

Iconscout blog post - resizing images on the fly
- Written by Tarun/Alex and reviewed by Richard Gee / Lucas
Roesler.

Signed-off-by: Alex Ellis <alexellis2@gmail.com>

@alexellis alexellis force-pushed the alexellis/iconscout branch from 13b0151 to d1a0ac7 Feb 7, 2019

Schedule Iconscout post for Friday
Signed-off-by: Alex Ellis <alexellis2@gmail.com>

@alexellis alexellis merged commit 8bd98cc into master Feb 7, 2019

@alexellis alexellis deleted the alexellis/iconscout branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment