Fix: Actually set headers in sinatra routes #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
koffeinfrei
force-pushed
the
fix/set-headers-in-sinatra
branch
from
6a899ee to
64ca2b8
Compare
The headers weren't actually set previously. The statement `headers = res_headers` doesn't have any effect, since it only creates a local variable. Signed-off-by: Alexis Reigel <mail@koffeinfrei.org>
koffeinfrei
force-pushed
the
fix/set-headers-in-sinatra
branch
from
64ca2b8 to
b8e5cd2
Compare
Contributor
Author
|
Closing this one as the change is included in #9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headers weren't actually set previously. The statement
headers = res_headersdoesn't have any effect, since it only creates a local variable. The correct statement would look likeheaders res_headers(i.e. call the methodheaders).I changed the code to use the return triplet
[status, headers, response body]though which is the recommended way (see http://sinatrarb.com/intro.html).