Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposing a Eclipse Vert.x native image template #66

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@pmlopes
Copy link
Contributor

pmlopes commented Mar 8, 2019

This PR will provide a Eclipse Vert.x native image template to the store.

@derek derek bot added the new-contributor label Mar 8, 2019

@derek

This comment has been minimized.

Copy link

derek bot commented Mar 8, 2019

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --sign-off and then git push --force.

@derek derek bot added the no-dco label Mar 8, 2019

@derek

This comment has been minimized.

Copy link

derek bot commented Mar 8, 2019

Thank you for your contribution. I've just checked and your Pull Request doesn't appear to have any description.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

@derek derek bot added the invalid label Mar 8, 2019

@pmlopes pmlopes force-pushed the pmlopes:patch-1 branch from efbe525 to 630fdb8 Mar 8, 2019

@pmlopes pmlopes referenced this pull request Mar 8, 2019

Closed

Vert.x Native template #118

@pmlopes

This comment has been minimized.

Copy link
Contributor Author

pmlopes commented Mar 8, 2019

This PR closes openfaas/templates#118

@alexellis
Copy link
Member

alexellis left a comment

LGTM, thank you 👍

@alexellis alexellis merged commit 9bcb9fe into openfaas:master Mar 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.