New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing console reading for csharp template #125

Merged
merged 1 commit into from Feb 9, 2019

Conversation

Projects
None yet
2 participants
@distantcam
Copy link
Contributor

distantcam commented Jan 31, 2019

Description

As discussed in #107 this PR changes the way the csharp template reads the console so that newline characters are not converted.

Motivation and Context

Issue #107

  • I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #107

How Has This Been Tested?

I reran the steps to reproduce from #107

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@derek

This comment has been minimized.

Copy link

derek bot commented Jan 31, 2019

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

Fixed console reading for csharp template
Signed-off-by: Cameron MacFarland <distantcam@gmail.com>

@distantcam distantcam force-pushed the distantcam:csharp-line-fix branch from e4a2bba to 911e2d6 Jan 31, 2019

@derek derek bot removed the no-dco label Jan 31, 2019

@alexellis
Copy link
Member

alexellis left a comment

LGTM

@alexellis alexellis merged commit f954524 into openfaas:master Feb 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Feb 9, 2019

Thank you!

@distantcam distantcam deleted the distantcam:csharp-line-fix branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment