New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Japanese version commands #78

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@toshi0607
Copy link

toshi0607 commented Oct 13, 2018

Original version commans were updated so Japanese version should also be updated.

Update Japanse version commands
Original version commans were updated so Japanese version should also be updated.

Signed-off-by: Toshinori Sugita <s.toshi0607@gmail.com>

@derek derek bot added the new-contributor label Oct 13, 2018


```
$ faas-cli deploy -f ./issue-bot.yml

This comment has been minimized.

@alexellis

alexellis Oct 13, 2018

Member

This one probably shouldn't change

This comment has been minimized.

@toshi0607

toshi0607 Oct 13, 2018

The line is deleted in this commit.
f27ff19#diff-9852b83ba9abfceda99773422ef371ac

And I think it will be deployed L72.

$ faas-cli up -f ./issue-bot.yml

This comment has been minimized.

@kenfdev

kenfdev Oct 13, 2018

Member

It looks like the original version has changed, too.
f27ff19#diff-9852b83ba9abfceda99773422ef371acR72

But yes, this only needs deploy because the environment variable is the only thing that changed. Perhaps we should revert it back to faas-cli deploy -f ./issue-bot.yml.

Revert original and Japanese version commands
The only thing that changed was the environment variable so we only need to redeploy.

Signed-off-by: Toshinori Sugita <s.toshi0607@gmail.com>
@kenfdev

This comment has been minimized.

Copy link
Member

kenfdev commented Oct 13, 2018

LGTM


```
$ faas-cli up -f ./issue-bot.yml

This comment has been minimized.

@alexellis

alexellis Oct 13, 2018

Member

Why did you remove faas-cli up?

This comment has been minimized.

@kenfdev

kenfdev Oct 13, 2018

Member

@alexellis This is getting confusing but started from this discussion:
#78 (comment)

I requested to revert the change:
#78 (comment)

But actually, this instruction is creating the function right before this place so it actually needs the faas-cli up. If that's true, d6e5d16 needs to be reverted. Alex, could you confirm?

@toshi0607 sorry about my misleading comment but could you revert the commit after Alex confirms?

This comment has been minimized.

@toshi0607

toshi0607 Oct 23, 2018

How is this going?

This comment has been minimized.

@kenfdev

kenfdev Dec 9, 2018

Member

@toshi0607 Sorry about the totally late response. Could you please revert this to $ faas-cli up -f ./issue-bot.yml ? So that it matches the original version.
Sorry about the back and forth 😢

@alexellis

This comment has been minimized.

Copy link
Member

alexellis commented Nov 7, 2018

@kenfdev please can you let me know if you want this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment