Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter reads by type restriction in direct relationship lookups #422

Merged
merged 5 commits into from Dec 19, 2022

Conversation

jon-whit
Copy link
Member

Description

Fixes an issue with filtered reads on direct relationship look ups.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jon-whit jon-whit requested a review from a team as a code owner December 19, 2022 15:53
craigpastro
craigpastro previously approved these changes Dec 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Base: 84.56% // Head: 84.57% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (f041070) compared to base (2c0b36c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   84.56%   84.57%   +0.01%     
==========================================
  Files          84       84              
  Lines       13763    13773      +10     
==========================================
+ Hits        11639    11649      +10     
  Misses       1746     1746              
  Partials      378      378              
Impacted Files Coverage Δ
server/commands/check_utils.go 99.04% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jon-whit jon-whit merged commit cdf2c76 into main Dec 19, 2022
7 checks passed
@jon-whit jon-whit deleted the fix-type-restriction-filtering branch December 19, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants