Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supprime et corrige scripts #1155

Merged
merged 13 commits into from
Oct 15, 2018
Merged

Supprime et corrige scripts #1155

merged 13 commits into from
Oct 15, 2018

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented Oct 10, 2018

  • Amélioration technique.
  • Périodes concernées : NA
  • Zones impactées : openfisca_france/scripts.
  • Détails :
    • Correction de scripts qui ne marchaient plus.
    • Documentation de scripts.
    • Suppression de scripts.

La majorité de scripts vieillissent très vite faute de tests. De ce fait, avant d'ajouter des tests il faut qu'on sache quels sont les scripts que l'on veut maintenir, et qu'on nettoie ceux qui n'ont maintenant qu'un valeur documentaire.

Deux sujets que je n'ai pas touché :

  • Performance
  • Barèmes IPP

Ces changements :

  • Corrigent/suppriment une fonctionnalité (scripts)

Fixes #1013


Quelques conseils à prendre en compte :

Copy link
Member

@benjello benjello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai juste corrigé une typo.

@Morendil Morendil force-pushed the remove-broken-scripts branch from 17c3c4e to 8c06514 Compare October 15, 2018 15:47
@Morendil Morendil merged commit 3043af5 into master Oct 15, 2018
@Morendil Morendil deleted the remove-broken-scripts branch October 15, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants